Great Circle Associates Majordomo-Users
(May 1994)
 

Indexed By Date: [Previous] [Next] Indexed By Thread: [Previous] [Next]

Subject: bug in 1.90 with mungedomain=yes
From: pdc @ lunch . asd . sgi . com (Paul Close)
Date: Tue, 17 May 1994 13:30:52 -0700 (PDT)
To: majordomo-workers @ greatcircle . com
Cc: majordomo-users @ greatcircle . com

Sorry I didn't find this sooner.  If you turn on mungedomain, addresses with
no '@' will always fail in addr_match.  The code in question is below:

    if ($partial == 2) { # see if addresses are foo@baz.bax.edu, foo@bax.edu
       local(@addr1,@addr2);
          @addr1 = split(/@/, $a1[0]);
          @addr2 = split(/@/, $a2[0]);
          if ( $#addr1 == $#addr2 && $#addr1 == 1 &&
               $addr1[0] eq $addr2[0] && (index($addr1[1], $addr2[1]) >= $[))
          {
            return(1);
          } else {
            return(undef);
          }
       }

The problem is, if addr1 has no '@' character, $#addr1 will not == 1, and
thus addr_match will fail.  I would suggest changing the first line to:

    # see if non-matching addresses are foo@baz.bax.edu, foo@bax.edu
    if ($partial == 2 && $a1[0] ne $a2[0]) {

-- 
Paul Close	     pdc@sgi.com	   ...!{ames, decwrl, uunet}!sgi!pdc

			No fate but what we make



Follow-Ups:
Indexed By Date Previous: Can some hostile addresses be parsed?
From: bill@biome.bio.ns.ca (Bill Silvert)
Next: Re: bug in 1.90 with mungedomain=yes
From: "John P. Rouillard" <rouilj@terminus.cs.umb.edu>
Indexed By Thread Previous: Re: Can some hostile addresses be parsed?
From: "John P. Rouillard" <rouilj@terminus.cs.umb.edu>
Next: Re: bug in 1.90 with mungedomain=yes
From: "John P. Rouillard" <rouilj@terminus.cs.umb.edu>

Google
 
Search Internet Search www.greatcircle.com