Great Circle Associates Majordomo-Users
(April 1997)
 

Indexed By Date: [Previous] [Next] Indexed By Thread: [Previous] [Next]

Subject: Patch to fix 'lists' display of subdirectories
From: "Kendall P. Bullen" <kendall @ lists . tax . org>
Date: Sat, 12 Apr 1997 02:51:33 -0400 (EDT)
To: majordomo-users @ greatcircle . com, majordomo-workers @ greatcircle . com

Hiya All,

For various reasons, I placed my digest and archive directories under
my lists directory.  Issuing a 'lists' command to majordomo shows both
subdirectories; it also creates .config files for these non-existent
lists.  I think that the 'lists' command should make sure the name
isn't a directory before treating it as a list.

I don't wish to get into a discussion about whether or not it is good
to have directories under the lists directory.  Whether you think it's
smart or stupid, the fact remains that majordomo shouldn't list a
directory as a list, when lists are in fact text files.  It should
skip directories, just as it skips files named RCS or core (what if I
created a list called core, or starting with core? I saw that it's
been mentioned before -- I fixed that line when I saw that in the web
archive of majordomo-users).

Anyway, I suggest adding a line linke the following (after the one
that checks for RCS|core) to the subroutine do_lists:

	next if (-d "$listdir/$list"); # skip directories

I tried this out and it worked fine.  :-) Since I don't recall if I've
patched majordomo in other ways, I don't want to try using diff to
create a patch (plus . . . it's *only* one line to add ;).  In my
possibly-not-pristine majordomo file, I inserted this line at 1198.

I'm posting this to majordomo-users in case anyone else has
subdirectories under their lists directory and could this this.  I'm
posting it to majordomo-workers in the hopes that, if there is a
1.94.2 (or if version 2 works similarly enough for this to apply),
this gets added.  I'd appreciate being told if this actually does get
into some future version of majordomo.

If this has been talked about before, then sorry to dredge it up again
(but consider me a vote for fixing this anyway ;).

Thanks,
Kendall


Indexed By Date Previous: Re: Invalid address.
From: Rodolfo Gonzalez Gonzalez <rgg@labpar1.cs.buap.mx>
Next: Re: Invalid address.
From: Michael Tratz <mailing@Esosoft.com>
Indexed By Thread Previous: Re: Invalid address.
From: Michael Tratz <mailing@Esosoft.com>
Next: Lock file problem?
From: David Gibbs <david@midrange.com>

Google
 
Search Internet Search www.greatcircle.com