Great Circle Associates Majordomo-Users
(June 2000)
 

Indexed By Date: [Previous] [Next] Indexed By Thread: [Previous] [Next]

Subject: Adding "Subject:" field
From: "Joe R. Jah" <jjah @ cloud . ccsf . cc . ca . us>
Date: Sun, 25 Jun 2000 20:13:16 -0700 (PDT)
To: Todd Lyons <todd @ mrball . net>
Cc: Majordomo-Users <majordomo-users @ GreatCircle . COM>
In-reply-to: <395616ED.71B6C412@mrball.net>
Reply-to: "Joe R. Jah" <jjah @ cloud . ccsf . cc . ca . us>

On Sun, 25 Jun 2000, Todd Lyons wrote:

> Date: Sun, 25 Jun 2000 07:27:57 -0700
> From: Todd Lyons <todd@mrball.net>
> To: Dan Liston <dliston@netscape.com>
> Cc: Thomas Hucke <hucke@uabcs.mx>,
>     majordomo-users <majordomo-users@GreatCircle.COM>
> Subject: Re: Changing From: field (Majordomo)
> 
> Dan Liston wrote:
> > 
> > This bug was supposed to be fixed in 1.94.5.  If this is the
> > version you are running, and it is still happening, I would
> > post to the majordomo-workers list and ask for a solution.
> > > `subject_prefix = [$LIST]` works only if you write anything else  into the
> > > Subject: field. If you let it blank it won't work. Do you have any idea 
> 
> It is still happening.  I run 1.94.5 on my list as well, and it does not
> prepend the defined subject_prefix if the original message has a blank
> subject.

The patch for 1.94.4, ftp://ftp.ccsf.org/majordomo-patches/1.94.4/resend.4
was determined to add a feature rather than fix a bug; therefore, it was
not included in 1.94.5 (bug fix) release.

I have ported it to 1.94.5, resend.1, and attached it to this email.  It
applies cleanly to an out-of-the-box 1.94.5.

 - Save the attachment to a file in your Majordomo server
 - Login as Majordomo user (e.g. majordom)
 - In Majordomo home run the following command:

      patch < /Patch/To/resend.1

You can also download it from:

	ftp://ftp.ccsf.org/majordomo-patches/1.94.5/resend.1

Regards,

Joe
-- 
     _/   _/_/_/       _/              ____________    __o
     _/   _/   _/      _/         ______________     _-\<,_
 _/  _/   _/_/_/   _/  _/                     ......(_)/ (_)
  _/_/ oe _/   _/.  _/_/ ah        jjah@cloud.ccsf.cc.ca.us
# This patch puts in a "Subject" header if none was given (but only if
# subject_prefix is set).
#
# Adopted from John Relph's patch against Majordomo 1.94.4
# Joe R. Jah <jjah@ccsf.org>
# 25 June 2000
#
# Against Majordomo 1.94.5
#

*** resend.orig	Fri Jan  7 07:32:39 2000
--- resend	Sun Jun 25 19:15:27 2000
***************
*** 579,584 ****
--- 579,585 ----
  sub parse_header {
      local($gonna_bounce);
      local($kept_last) = 0;			      # our return flag/string.
+     local($subject_found) = 0;
  
      print STDERR "$0: parse_header: enter.\n" if $DEBUG;
      print STDERR "$0: parse_header:  taboo_headers = $is_taboo_header\n" if $DEBUG;
***************
*** 708,713 ****
--- 709,715 ----
  	    local($foo_pat) = $foo;
  	    $foo_pat =~ s/(\W)/\\$1/g;
  	    s/^subject:[^\S\n]*/Subject: $foo /i if !/$foo_pat/; 
+ 	    $subject_found = 1;
  	}
  	
  	# snag reply-to field 
***************
*** 754,759 ****
--- 756,770 ----
      if (defined($opt_r)) {
  	print OUT "Reply-To: ", &config'substitute_values($opt_r), "\n";   #';
      }
+ 
+     if (($subject_found == 0)
+ 	&& ($config_opts{$opt_l,"subject_prefix"} ne '')) {
+ 
+ 	print STDERR "$0: parse_header: adding subject prefix\n" if $DEBUG;
+ 	print OUT "Subject: ",
+ 	   &config'substitute_values($config_opts{$opt_l,"subject_prefix"}, $opt_l), #'
+ 	   " (none)\n";
+     }
      
      # print out per-list additonal headers
      if ( $config_opts{$opt_l,"message_headers"} ne '' ) {

References:
Indexed By Date Previous: Re: majordomo2
From: John W Baxter <jwblist@olympus.net>
Next: Need help with the "Cannot open /usr/lib/majordomo/lists/test" problem
From: "Pan, Julie" <pan@tri.sbc.com>
Indexed By Thread Previous: Re: Changing From: field (Majordomo)
From: Todd Lyons <todd@mrball.net>
Next: [no subject]
From: Chip Hearn <chearn@unitedcomptech.com>

Google
 
Search Internet Search www.greatcircle.com