I was groveling through majordomo and noticed that a lot of things
weren't quite "up to snuff" as far as perl idioms goes. For example:
eval(`cat $cf`)
instead of
require "$cf"
and
sub foo {
local($a) = shift;
local($b) = shift;
...
}
instead of:
sub foo {
local($a, $b) = @_;
@_ = ();
}
etc. Since Brent was just learning perl when he wrote this, it is easy
to see why the code was written this way. Is anybody interested in
taking 1.9x, and cleaning up the code to look a bit more idiomatic.
Note you would have to check to make sure that you didn't break things
during the upgrade, but it would sure be nicer, and I think in a few
places it would be better performance wise as well.
-- John
John Rouillard
Senior Systems Consultant (SERL Project) University of Massachusetts at Boston
rouilj@cs.umb.edu (preferred) Boston, MA, (617) 287-6480
==============================================================================
My employers don't acknowledge my existence much less my opinions.
|
|
