Claude Cantin <cantin@nickel.sao.nrc.ca> writes:
#
# I'm running majordomo 1.92 on IRIX 5.2. I notice that my "approve"
# perl program has something wrong with it (within the process_bounce routine):
#
# 187
# 188 warn "Can't find password for list $list, Stopped" , return
# 189 if !defined($passwd{$list});
#
# Lines 187 to 190 do not seem logical to me.
That's legitimate (if strange) perl syntax. It's basicly the same as:
if (!defined($passwd{$list})) {
warn "Can't find password for list $list, Stopped";
return;
}
Basicly, it says that if "approve" can't find a password for the
relevant list (i.e., it's not in your .majordomo file), to give up.
I think that, when you modify a program, you should stick to the
original style of the program (even if that's not their normal style),
and this code is definitely _not_ in the original style of the
program, but I don't have any active role in Majordomo development any
more, so all I can really do is grumble about it.
-Brent
--
Brent Chapman | Great Circle Associates | Call or email for info about
Brent@GreatCircle.COM | 1057 West Dana Street | upcoming Internet Security
+1 415 962 0841 | Mountain View, CA 94041 | Firewalls Tutorial dates
Follow-Ups:
|
|
