Great Circle Associates Majordomo-Workers
(June 1995)
 

Indexed By Date: [Previous] [Next] Indexed By Thread: [Previous] [Next]

Subject: Minor bug in 1.93
From: dwolfe @ risc . sps . mot . com (Dave Wolfe)
Date: Tue, 20 Jun 1995 20:42:16 -0500 (CDT)
To: majordomo-workers @ greatcircle . com (Majordomo developer's mailing list)
Reply-to: David Wolfe <david_wolfe @ risc . sps . mot . com>

Sorry if this is old news, but I just got bit by a rather arcane bug in
majordomo. Seems that I'd been diff'ing some lists and left a scratch
file lying around that was owned by me and unreadable by mj. Someone
subsequently mails a which request to mj causing do_which to pick up
this file as a list file. When it tries to check to see if the requester
is mentioned in this file it gets an open error and aborts at line 467.
Unfortunately, the abort message uses $_, whereas the open uses $list,
to identify the failing list name, so the abort message is, shall we
say, less than informative. Here's the fix (line numbers refer to the
original 1.93 distribution):

*** majordomo.orig      Wed Mar  1 08:43:23 1995
--- majordomo   Tue Jun 20 20:28:23 1995
***************
*** 464,470 ****
            # skip private lists that the requestor isn't a member of
            next;
        }
!       open(LIST, "$listdir/$list") || &abort("Can't open list $listdir/$_");
        while (<LIST>) {
            $_ = &chop_nl($_);
            if (&addr_match($_, $subscriber, 1)) {
--- 464,471 ----
            # skip private lists that the requestor isn't a member of
            next;
        }
!       open(LIST, "$listdir/$list") ||
!           &abort("Can't open list $listdir/$list");
        while (<LIST>) {
            $_ = &chop_nl($_);
            if (&addr_match($_, $subscriber, 1)) {

-- 
 Dave Wolfe    *Not a spokesman for Motorola*  (512) 891-3246
 Motorola MMTG  6501 Wm. Cannon Dr. W. OE112  Austin  TX  78735-8598

Indexed By Date Previous: majordomo 1.93 bug?
From: "Joseph Kwan" <jkwan@ampersand.Jpl.Nasa.Gov>
Next: ofs/1 MajorDomo
From: Michael Bukhin <mikeb@village.com>
Indexed By Thread Previous: majordomo 1.93 bug?
From: "Joseph Kwan" <jkwan@ampersand.Jpl.Nasa.Gov>
Next: ofs/1 MajorDomo
From: Michael Bukhin <mikeb@village.com>

Google
 
Search Internet Search www.greatcircle.com