I did a full install from scratch of 1.94.1 + Dave's replacement Makefile.
Some comments, in no particular order:
The new Makefile looks nice. I think I'd like to be able to choose the
permissions that things are installed with; I much prefer 775 (771 for
$homedir) so that I don't have to su all the time. No biggie, though; I
just do "chmod -R g+w ^wrapper" as root.
Because mkdir -p is used, the man directory gets automatically created but
its ownership doesn't get changed. It kind of looks funny.
A bin directory is created, but nothing is put in it. approve, bounce, and
medit have been moved into $homedir. I suppose this makes sense for medit
because it needs to be run under the wrapper, but approve and bounce can be
anywhere. Also, things are still in Tools that should be in $homedir, like
archive2.pl and digest. (But this is tricky; some might use one of the
other archivers.)
config-test wants to compare against sample.cf, but sample.cf isn't
installed. This causes config-test to fail until it's copied over
manually.
A copy of the registration message should be sent to majordomo-owner. I
know it's sending mail, but because I'm paranoid I want to see what its
mailing. It could be sending /etc/passwd or /etc/aliases (to get those
outgoing aliases, I guess). I just know Brent's out to get me.
There are some extra-long comments that need to be line wrapped in the
loadavg stuff. (Yeah, I'm picky, but Emacs does it all for me.)
If we're going to do this in an incomplete fashion now, we should at least
to it as well as we can:
--- sample.cf.orig Mon Nov 25 02:06:16 1996
+++ sample.cf Tue Nov 26 00:04:31 1996
@@ -295,5 +295,9 @@
$global_taboo_body = <<'END';
END
+# The majordomo will not send replies to addresses which match this.
+# The match is done case-insensitively.
+$majordomo_dont_reply = '(mailer-daemon|uucp|listserv|majordomo)\@';
+
1;
# $Header: /sources/cvsrepos/majordomo/sample.cf,v 1.25 1996/11/22 16:35:58 cwilson Exp $
--- majordomo.orig Mon Nov 25 02:06:20 1996
+++ majordomo Mon Nov 25 02:13:05 1996
@@ -130,7 +130,7 @@
}
# robots should not reply to other robots...
-if ($reply_to =~ m/(mailer-daemon|uucp|listserv|majordomo)\@/i) {
+if ($reply_to =~ m/$majordomo_dont_reply/i) {
print STDERR "$whoami: not replying to $1 to avoid mail loop.\n";
exit 0;
}
(feel free to chose a better variable name). Also, perhaps it should
&abort (so the owner gets a message) instead of just printing to STDERR.
More to come as I hack. I'll try to work up patches to these problems if
nobody else beats me to it.
- J<
Follow-Ups:
|
|
