[ Chan Wilson writes: ]
>
> > The following lines in shlock.pl is trouble:
> >
> > open($FH_name, ">> $filename") ||
> > &warn("open of temp file $filename failed\n $!");
> >
> > It causes an infinite stream of warnings to Majordomo owners from
> > majordomo process that lingers instead of dying like it's suppose to.
> > Why not?:
> >
> > open($FH_name, ">> $filename") ||
> > die "open of temp file $filename failed\n $!";
> >
>
> Because then nobody likely hears about the problem.
>
> There's a fix for this in the 1.94.1 test patch I posted several days
> ago. If you apply it, apply the patches from Dave and Jason as well,
> or wait until I roll those in and send the patch out again.
There is? I don't see anything in 1.94.1 that effects that. Not in
shlock.pl anyway. I agree that it's inappropriate to die there, but I
don't see how it gets out of open_temp without a slew of other warning
messages. I suspect the fix is to add a 'return undef;' after the
'warn' (all within braces, of course).
--
Dave Wolfe
Follow-Ups:
References:
|
|
