Great Circle Associates Majordomo-Workers
(November 1996)
 

Indexed By Date: [Previous] [Next] Indexed By Thread: [Previous] [Next]

Subject: config-test patch
From: Jason L Tibbitts III <tibbs @ hpc . uh . edu>
Date: 27 Nov 1996 01:33:17 -0600
To: majordomo-workers @ greatcircle . com

This fixes some typos in config-test that prevented the new and unknown
variable checking from doing much of anything at all.  It also sends a copy
of the registration mail to $whoami_owner to help ensure that people don't
freak out.

Is anyone else playing with 1.94.1?  The fact that nobody else mentioned
that resend failed to compile leads me to believe the either I botched the
patch or that nobody else is testing this.  I hope it's the former.

 - J<

--- config-test.orig	Wed Nov 27 00:57:57 1996
+++ config-test	Wed Nov 27 01:12:39 1996
@@ -221,12 +221,12 @@
 open(S, 'sample.cf') || &bad("Couldn't open sample.cf for reading, $!");
 
 while (<S>) {
-    next if !/^($\w+)/;
+    next if !/^(\$\w+)/;
     $config{$1} = 2;
 }
 
 while (<$cf>) {
-    next if !/^($\w+)/;
+    next if !/^(\$\w+)/;
     $config{$1}++;
 }
 
@@ -243,12 +243,12 @@
     push (@unknown, $_) if $config{$_} == 1;
 }
 
-if ($#new > 0) {
+if ($#new >= 0) {
     print "\nNew configuration variables (see sample.cf):\n";
     foreach (@new) { print "\t$_\n"; }
 }
 
-if ($#unknown > 0) {
+if ($#unknown >= 0) {
     print "\nUnknown configuration variables in existing majordomo.cf:\n";
     foreach (@unknown) { print "\t$_\n"; }
 }
@@ -287,10 +287,11 @@
 I see you haven't registered this version of Majordomo.
 By registering, you will be notified of patches and further releases
 of Majordomo.  Shall I send email to majordomo-registration\@greatcircle.com
+to register this version ($whoami_owner
 ZOT
 
 #'
-    print "to register this version?  [y] ";
+    print "will also be sent a copy)?  [y] ";
 	if ( <> !~ /n/i) {
 	    open(f,">$registration_file") 
 		|| die "couldn't create $registration_file, $!";
@@ -306,7 +307,7 @@
 	    &set_mail_sender($whoami_owner);
 	    &set_mailer($bounce_mailer);
 
-	    &sendmail(REG, "majordomo-registration\@greatcircle.com", 
+	    &sendmail(REG, "majordomo-registration\@greatcircle.com,$whoami_owner", 
 		      "Majordomo Registration");
 	    print REG "Majordomo Version: $majordomo_version\n";
 	    print REG "Perl version $]\n";


Follow-Ups:
Indexed By Date Previous: 1.94.1 Makefile patch
From: Jason L Tibbitts III <tibbs@hpc.uh.edu>
Next: Re: 1.94.1 Makefile patch
From: Jason L Tibbitts III <tibbs@hpc.uh.edu>
Indexed By Thread Previous: Re: config-test
From: Brock Rozen <brozen@webdreams.com>
Next: Re: config-test patch
From: Dave Wolfe <dwolfe@risc.sps.mot.com>

Google
 
Search Internet Search www.greatcircle.com