Great Circle Associates Majordomo-Workers
(March 1997)
 

Indexed By Date: [Previous] [Next] Indexed By Thread: [Previous] [Next]

Subject: Re: A few patches against mj 1.94.1
From: Dave Wolfe <dwolfe @ risc . sps . mot . com>
Date: Thu, 20 Mar 1997 12:41:31 -0600 (CST)
To: ed @ fidalgo . net (Ed Jordan)
Cc: majordomo-workers @ GreatCircle . COM
In-reply-to: <no.id> from "Ed Jordan" at Mar 20, 97 02:09:03 pm
Reply-to: Dave Wolfe <david_wolfe @ risc . sps . mot . com>

[ Ed Jordan writes: ]
> 
> --- bin/approve.orig	Tue Feb 25 10:45:57 1997
> +++ bin/approve	Fri Feb 28 13:32:10 1997
[...]
> @@ -106,20 +106,25 @@
>  	    $reply_to = $_;
>  	    $reply_to =~ tr/A-Z/a-z/;
>  	    next;
> -	}
> -	if (/^subject:/i) {
> +	} elsif (/^from:/i) {
> +	    s/^\S*:\s+//;
> +	    $from = $_;
> +	    $from =~ tr/A-Z/a-z/;
> +	    next;
> +	} elsif (/^subject:/i) {
>  	    s/^\S*:\s+//;
>  	    $subject = $_;
>  	    $subject =~ tr/A-Z/a-z/;
>  	    ($request, $list) = split(/\s/, $subject, 2);
>  	    $list =~ s/:.*//;
>  	    next;
> -	}
> -	if (/^$/) {
> +	} elsif (/^$/) {
>  	    last;
>  	}
>      }
>  
> +    $reply_to = $from unless defined($reply_to); # seems reasonable
> +
>      # we've read the headers, so we should know now if this is an "APPROVE"
>      # or a "BOUNCE" that we're processing.
>  

This patch will break approve. Bounce messages, as sent by resend, don't
contain a Reply-To: header but do contain a From: header referring to
the list owner. Approve resolves this by using the list name from the
.majordomo file when $reply_to is undefined. This patch would set the
$reply_to variable from the From: header and mail the approval back to
the list owner instead of the list.

-- 
 Dave Wolfe


Follow-Ups:
Indexed By Date Previous: Re: A few patches against mj 1.94.1
From: Dave Wolfe <dwolfe@risc.sps.mot.com>
Next: Syntax for a 'set' command?
From: Jason L Tibbitts III <tibbs@hpc.uh.edu>
Indexed By Thread Previous: Re: A few patches against mj 1.94.1
From: Jason L Tibbitts III <tibbs@hpc.uh.edu>
Next: Re: A few patches against mj 1.94.1
From: Ed Jordan <ed@fidalgo.net>

Google
 
Search Internet Search www.greatcircle.com