Great Circle Associates Majordomo-Workers
(December 1999)
 

Indexed By Date: [Previous] [Next] Indexed By Thread: [Previous] [Next]

Subject: More issues, some patches
From: Oliver Xymoron <oxymoron @ waste . org>
Date: Sun, 12 Dec 1999 17:00:04 -0600 (CST)
To: majordomo-workers @ greatcircle . com
Cc: Jason L Tibbitts III <tibbs @ hpc . uh . edu>, grimes @ waste . org

Some notes I've been taking while working on moving some lists to MJ2:

'core' should be a valid list name
 little danger of confusing corefile with new list in MJ2
 little danger of core getting dropped in top directory

password step on install should be optional
 for when you change source and want to copy it over

default list passwords "<list>.pass" are unsafe!
 should mail generated password to list owner

list owner appears to be ignored on createlist

default list settings are unsafe!
 if the subscriber list is open, other list security is irrelevant
 should default to closed who/which and restrict post
 might default noadvertise and closed subscribe as well
   so that there's never a setup race

the DEBUG subject thing should be off by default somehow
 when off, using it tells you how to enable it in source?

need hook for calling external program on MTA config rewrites

archive directory should be created by default or a createlist flag

need a script to add new domains
 where is the code that does this now? it should be made stand-alone

how can a moderator insert comments into messages they're approving?

where do I put hooks for per-message search indexing?


I made some small doco and code changes as well:

Index: files/en/config/advertise
===================================================================
RCS file: /home/cvs/majordomo/majordomo/files/en/config/advertise,v
retrieving revision 1.1
diff -u -r1.1 advertise
--- files/en/config/advertise	1999/02/28 07:01:27	1.1
+++ files/en/config/advertise	1999/12/12 22:41:14
@@ -1,3 +1,3 @@
 If the requestor name matches one of these regexps, then the list will
-not be listed in the output of a lists command.  Noadvertise overrides
+be listed in the output of a lists command.  Noadvertise overrides
 advertise.
Index: files/en/config/message_footer_frequency
===================================================================
RCS file: /home/cvs/majordomo/majordomo/files/en/config/message_footer_frequency,v
retrieving revision 1.1
diff -u -r1.1 message_footer_frequency
--- files/en/config/message_footer_frequency	1999/02/28 07:01:36	1.1
+++ files/en/config/message_footer_frequency	1999/12/12 22:41:15
@@ -1,6 +1,6 @@
 Controls how often a message_footer will be added to outgoing
 messages.  Set this to a number and on average footers will be added
-to that percentage of messagees.  If this is set to 100 or greater,
+to that percentage of messages.  If this is set to 100 or greater,
 footers will always be added.  If set to 0 or below, footers will
 never be added (even if footers are defined).
 
Index: files/en/config/moderator_group
===================================================================
RCS file: /home/cvs/majordomo/majordomo/files/en/config/moderator_group,v
retrieving revision 1.1
diff -u -r1.1 moderator_group
--- files/en/config/moderator_group	1999/02/28 07:01:37	1.1
+++ files/en/config/moderator_group	1999/12/12 22:41:15
@@ -1,3 +1,3 @@
-List messages requiring consulataion will be sent to this many of the
+List messages requiring consultation will be sent to this many of the
 addresses in 'moderators', chosen at random.  If this is zero, the
 message will be sent to all of the addresses in 'moderators'.
Index: lib/Majordomo.pm
===================================================================
RCS file: /home/cvs/majordomo/majordomo/lib/Majordomo.pm,v
retrieving revision 1.108
diff -u -r1.108 Majordomo.pm
--- lib/Majordomo.pm	1999/10/03 23:40:04	1.108
+++ lib/Majordomo.pm	1999/12/12 22:41:17
@@ -2218,7 +2218,7 @@
   return undef if $name =~ /[^a-zA-Z0-9-_.]/;
   return undef if $name eq '.';
   return undef if $name eq '..';
-  return undef if $name =~/^(RCS|core)$/;
+  return undef if $name =~/^(RCS)$/;
   return 1;
 }
 
Index: lib/Mj/CommandProps.pm
===================================================================
RCS file: /home/cvs/majordomo/majordomo/lib/Mj/CommandProps.pm,v
retrieving revision 1.19
diff -u -r1.19 CommandProps.pm
--- lib/Mj/CommandProps.pm	1999/10/12 03:18:55	1.19
+++ lib/Mj/CommandProps.pm	1999/12/12 22:41:17
@@ -68,7 +68,13 @@
    'default'    => {'parser' => [qw(email shell_parsed real)]},
    'end'        => {'parser' => [qw(email shell interp)]},
    'config'     => {'parser' => [qw(email list obsolete=configshow real)]},
-   'configshow' => {'parser' => [qw(email shell list global real)]},
+   'configshow' => {'parser' => [qw(email shell list global real)],
+		    'access'   => {
+			'default' => 'deny',
+			'legal'   => \%reg_legal,
+			'actions' => \%actions,
+		    },
+		},
    'configset'  => {'parser' => [qw(email shell list global real)]},
    'configdef'  => {'parser' => [qw(email shell list global real)]},
    'configedit' => {'parser' => [qw(shell list global real)]},
Index: lib/Mj/MTAConfig.pm
===================================================================
RCS file: /home/cvs/majordomo/majordomo/lib/Mj/MTAConfig.pm,v
retrieving revision 1.20
diff -u -r1.20 MTAConfig.pm
--- lib/Mj/MTAConfig.pm	1999/07/04 21:22:50	1.20
+++ lib/Mj/MTAConfig.pm	1999/12/12 22:41:17
@@ -155,7 +155,7 @@
 # Aliases for Majordomo at $dom
 $who$vut:       "|$bin/mj_enqueue -m -d $dom$debug"
 $who$vut-owner: "|$bin/mj_enqueue -o -d $dom$debug"
-owner-$who$vut: $who$vut-owner,
+owner-$who$vut: $who$vut-owner
 # End aliases for Majordomo at $dom
 EOB
 
@@ -172,7 +172,7 @@
 # Aliases for Majordomo at $dom
 $who$vut:       "|$bin/mj_email -m -d $dom$debug"
 $who$vut-owner: "|$bin/mj_email -o -d $dom$debug"
-owner-$who$vut: $who$vut-owner,
+owner-$who$vut: $who$vut-owner
 # End aliases for Majordomo at $dom
 EOB
 
@@ -192,7 +192,7 @@
 $list$vut:         "|$bin/mj_enqueue -r -d $dom -l $list$debug"
 $list$vut-request: "|$bin/mj_enqueue -q -d $dom -l $list$debug"
 $list$vut-owner:   "|$bin/mj_enqueue -o -d $dom -l $list$debug"
-owner-$list$vut:   $list-owner,
+owner-$list$vut:   $list$vut-owner
 # End aliases for $list at $dom
 EOB
       $vblock = <<"EOB";

--
 "Love the dolphins," she advised him. "Write by W.A.S.T.E.." 



Follow-Ups:
Indexed By Date Previous: Aliases, man dir, configshow
From: Oliver Xymoron <oxymoron@waste.org>
Next: Re: More issues, some patches
From: Dave Wolfe <dwolfe@risc.sps.mot.com>
Indexed By Thread Previous: Aliases, man dir, configshow
From: Oliver Xymoron <oxymoron@waste.org>
Next: Re: More issues, some patches
From: Dave Wolfe <dwolfe@risc.sps.mot.com>

Google
 
Search Internet Search www.greatcircle.com